cleanup2 #874

Merged
merged 8 commits into from Apr 29, 2015

Projects

None yet

3 participants

@xxorde
xxorde commented Apr 28, 2015

As mentioned in #850 I did some permission cleanup.

  • set direct execute scripts to 755
    • *.py *.sh *.pl
  • set most .php to 0644
    • *.php in the root (/) untouched
    • * left /scripts/ and /upgrade-scripts/ untouched
  • set images, html, txt and MIBs to 644
  • removed html/images/16/Thumbs.db

I tested it (only) on my own setup.

@xxorde xxorde referenced this pull request Apr 28, 2015
Closed

cleanup #850

@paulgear
Member

Looks good to me; no new Scrutinizer issues introduced.

@laf
Member
laf commented Apr 28, 2015

@paulgear Unless you're planning to merge this I can run it on my test install overnight tonight and merge tomorrow if you like?

@paulgear
Member

@xxorde, I found a few files that shouldn't have been changed: daily.sh, html/js/makemini.pl, mibs/process.pl, scripts/removespikes.pl, scripts/watchmaillog/watchmaillog.pl - if you change these back to 755 and push to your branch, this PR will update automatically.

@xxorde
xxorde commented Apr 29, 2015

@paulgear you mean I should change them back to 0644, right?
I made them 0755 on my branch.

@paulgear
Member

Apologies, @xxorde - I was reading the diff the wrong way around. In that case, these files could use a chmod 644:
mibs/ATM-FORUM-ADDR-REG
mibs/CABLETRON-TRAPS
mibs/CABLETRON-TRAPS-IRM
mibs/CISCOSB-AAA
mibs/CISCOSB-BRIDGE-SECURITY
mibs/CISCOSB-File
mibs/CISCOSB-HWENVIROMENT
mibs/CISCOSB-IP
mibs/CISCOSB-IPv6
mibs/CISCOSB-IpRouter
mibs/CISCOSB-MAC-BASE-PRIO
mibs/CISCOSB-RMON
mibs/CISCOSB-SECURITY-SUITE
mibs/CISCOSB-SSL
mibs/CISCOSB-TCPSESSIONS
mibs/CISCOSB-Tuning
mibs/CISCOSB-UDP
mibs/CISCOSB-rlFft
mibs/CISCOSB-rlInterfaces
mibs/CISCOSB-rndApplications
mibs/CISCOSB-rndMng
mibs/IRM-OIDS
mibs/NETWORK-DIAGS
mibs/RBTWS-AP-TC
mibs/RBTWS-CLIENT-SESSION-TC
mibs/REPEATER-MIB-2
mibs/ROUTER-OIDS

@xxorde
xxorde commented Apr 29, 2015

@paulgear you are right, I forgot to change these MIBs to 0644.

@laf laf merged commit 8a0394d into librenms:master Apr 29, 2015

1 check passed

Scrutinizer 2309 Issues, 21 Patches
Details
@joubertredrat joubertredrat pushed a commit to joubertredrat/librenms that referenced this pull request Apr 29, 2015
@laf laf Squashed 'html/js/datetime/' changes from 5b3fc61..e750af7
e750af7 Update README.md
805bcc3 Update CONTRIBUTING.md
613a583 Update CONTRIBUTING.md
31e50cc Update bootstrap-datetimepicker-build.less
d004434 Merge pull request #891 from Eonasdan/development
adc8a68 fixes #867
8e16324 fixing locale formatting
dfe5657 patch #752
b2a71de fixes #874
d00e39d version bump
762a90d couple of fixes
d072d92 added keepInvalid
8eae1a4 Fixes and some new features
7f7dff4 Merge pull request #802 from zpaulovics/development
28699b6 Merge pull request #818 from mcarepa/improv-picker-placement
0abdcb1 Merge pull request #828 from ahmader/development
a9744c5 Merge pull request #831 from admackin/development
86b49cb Update package.json
ea501fa Fixes #793
0c5ad39 quick typo fixs
1cff47b picker placement conditions updated
6d245c9 version bump
a4e7201 fixes and new features
a865edf Revert "flipping events again"
78e28f5 Revert "tests"
b7ae1e3 Fixed the options handling for componets
197647d tests
8d0fef8 flipping events again
8daa2b2 fix for #794
0221cb4 Merge pull request #778 from davidrojo/iss777
c11f3be Merge pull request #789 from comerc/patch-5
159d29e Update bootstrap-datetimepicker.js
b545f2a Fixed coding style
19b485a Fixed coding style
6066555 Update CONTRIBUTING.md
1b2fe6e Update CONTRIBUTING.md
8d5b40a Fixes #777
37d8ce1 fix for #760
1cae292 fix for #761
499f619 fixing less
557b657 updating to v4
d9560b3 Update CONTRIBUTING.md
29b397d Update README.md
29cd87f Update bower.json
fc56ea1 fixes #664
4c74e82 Merge pull request #635 from PeterDaveHello/patch-1
d756797 fix indent in package.json

git-subtree-dir: html/js/datetime
git-subtree-split: e750af7a4a65870030056a83fd1b52fc7b343246
65c3d1b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment