Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mimosa PtP frequency and power #8741

Merged
merged 1 commit into from May 20, 2018

Conversation

Projects
None yet
2 participants
@murrant
Copy link
Member

murrant commented May 19, 2018

Add test data
There were also some sensor name collisions and an incorrect divisor.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

This comment has been minimized.

Copy link
Member

laf commented May 19, 2018

Is this going to lose data because of the index changes?

@murrant

This comment has been minimized.

Copy link
Member Author

murrant commented May 20, 2018

Data is not working currently or is incorrect previously as far as I can tell.

@laf

laf approved these changes May 20, 2018

Copy link
Member

laf left a comment

LGTM

@laf laf merged commit c18bc38 into librenms:master May 20, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:bfive branch May 20, 2018

@laf laf added the Bug 🐞 label May 30, 2018

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

fix: Fixed Mimosa PtP frequency and power (librenms#8741)
Add test data
There were also some sensor name collisions and an incorrect divisor.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.