Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Added SFP sensor discovery for Procurve devices #8746
Procurve devices have SPF ports. If those are filled with SPF modules with DOM support, sensor data will be available through SNMP. Tested on J9775A 2530-48G switches.
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
I've left a few comments in line. We normally would want this in yaml format but as you access some other data that would be silly to snmpwalk for now then we can leave it for now and convert this later when we can cache snmp data.
You have two blank lines in each of your new files, can you remove the second so only one line exists.
Also, we need test data for this: https://docs.librenms.org/#Developing/os/Test-Units/#example-workflow
That was painful, but I think the changes have been pushed in the end.
As per the tests, I followed "Additional module support or test data" part. Snmprec file has been populated, but the following steps were faulty - snmpsim threw out a ton of errors on "save-test-data" step and "pre-commit" step succeeded at first run, but then started to fail.