New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved support for DNOS/FTOS M-Series #8749

Merged
merged 6 commits into from Jun 16, 2018

Conversation

Projects
None yet
3 participants
@skoef
Contributor

skoef commented May 22, 2018

Current implementation for Force10 series doesn't support the switch-blade M-Series model. This PR adds support for mempools and temperature. In my test environment (still 1.31) I have processors utilization support as well, but I have to test that in the new way processors are handled since 1.37

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@CLAassistant

This comment has been minimized.

CLAassistant commented May 22, 2018

CLA assistant check
All committers have signed the CLA.

@laf

Thanks for doing this.

We need some test data for this, please use a variant to create a new file such as mseries: https://docs.librenms.org/#Developing/os/Test-Units/#example-workflow

@laf

This comment has been minimized.

Member

laf commented Jun 13, 2018

@skoef Any update on this?

@skoef

This comment has been minimized.

Contributor

skoef commented Jun 14, 2018

I've executed all the steps in the example workflow. I did have some failed tests unrelated to my change, but I'm not sure why this error is popping up.

@laf

This comment has been minimized.

Member

laf commented Jun 15, 2018

Looks like you had some mibs locally you haven't uploaded here. I've added those and re-ran the test. Should be ok now.

@laf laf added the Device 🖥 label Jun 15, 2018

@skoef

This comment has been minimized.

Contributor

skoef commented Jun 16, 2018

Cool thanks!

@laf

laf approved these changes Jun 16, 2018

LGTM

@laf laf merged commit 7b182e2 into librenms:master Jun 16, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

laf added a commit that referenced this pull request Jun 16, 2018

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

Improved support for DNOS/FTOS M-Series (librenms#8749)
Current implementation for Force10 series doesn't support the switch-blade M-Series model. This PR adds support for mempools and temperature. In my test environment (still 1.31) I have processors utilization support as well, but I have to test that in the new way processors are handled since 1.37

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

@lock lock bot locked as resolved and limited conversation to collaborators Aug 15, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.