New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CISCO-VRF-MIB for vrfs on non MPLS cisco devices #8756

Merged
merged 8 commits into from May 26, 2018

Conversation

Projects
None yet
3 participants
@vivia11
Contributor

vivia11 commented May 23, 2018

Hi all,

Reopening this PR because I pushed too many commits to the other branch.

Referencing: GH-8683

DO NOT DELETE THIS TEXT

Thanks to PipoCanaja for providing the snmp data.

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

vivia11 and others added some commits May 23, 2018

@murrant

Fixed up the test data collection

@murrant

We got it ;)

@murrant murrant merged commit 94693b0 into librenms:master May 26, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@vivia11 vivia11 deleted the vivia11:vrfs branch May 28, 2018

@laf laf added the Device 🖥 label May 30, 2018

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

Use CISCO-VRF-MIB for vrfs on non MPLS cisco devices (librenms#8756)
* Add vrf for non mpls cisco devices, add mib and test data

* Fix custom_where in vrf module

* Better VRF module test data collection

* Update ios_6500.json

* don't include ifVrf in ports

* update all ports add dependencies to pre-commit.php

* new json files

@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.