New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change alert rule triggered icon from X to ! #8760

Merged
merged 1 commit into from May 24, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented May 24, 2018

image

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@kkrumm1 kkrumm1 added the WebUI label May 24, 2018

@laf

laf approved these changes May 24, 2018

LGTM

@laf laf merged commit b0968e8 into librenms:master May 24, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:alert-exclamation branch May 24, 2018

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

webui: Changed alert rule triggered icon from X to ! (librenms#8760)
![image](https://user-images.githubusercontent.com/39462/40490177-981b5a78-5f30-11e8-949d-2353272b334b.png)


DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

@lock lock bot locked as resolved and limited conversation to collaborators Jul 23, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.