New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EfficientIP SOLIDserver Detections #8773

Merged
merged 8 commits into from Jun 15, 2018

Conversation

Projects
None yet
2 participants
@centralscrutiniser
Contributor

centralscrutiniser commented May 26, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

  • Added initial detection for EfficientIP SOLIDserver
@laf

A question over the OS name. Can you also delete html/images/logos/eip.png, it's not needed when the os one exists and it's the same.

@@ -0,0 +1,13 @@
os: efficientip

This comment has been minimized.

@laf

laf May 27, 2018

Member

efficientip is the company isn't it? It should be named after the OS that the devices run. If the OS doesn't have a name then use solidserver.

centralscrutiniser and others added some commits May 28, 2018

@laf

This comment has been minimized.

Member

laf commented Jun 13, 2018

I've pushed the other test file up, once it passes this is good.

@laf laf added the Device 🖥 label Jun 15, 2018

laf added some commits Jun 15, 2018

@laf

laf approved these changes Jun 15, 2018

@laf laf merged commit 646a37f into librenms:master Jun 15, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

Added detection for EfficientIP SOLIDserver (librenms#8773)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

- Added initial detection for EfficientIP SOLIDserver

@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.