Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device: Adding sensors to omnitron iconverter #8806

Merged
merged 1 commit into from Jun 6, 2018

Conversation

Projects
None yet
2 participants
@vivia11
Copy link
Contributor

vivia11 commented Jun 6, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@laf

laf approved these changes Jun 6, 2018

Copy link
Member

laf left a comment

LGTM.

Perfect PR. Thanks as always @vivia11 :)

@laf laf added the Device 🖥 label Jun 6, 2018

@laf laf merged commit 7eb107a into librenms:master Jun 6, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@vivia11 vivia11 deleted the vivia11:omnitron branch Jun 15, 2018

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

Added additional sensors to omnitron iconverter (librenms#8806)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

@lock lock bot locked as resolved and limited conversation to collaborators Aug 14, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.