New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the hostname to resolve to the sysName, ie Dynamic DNS #8810

Merged
merged 1 commit into from Jun 23, 2018

Conversation

Projects
None yet
3 participants
@InsaneSplash
Contributor

InsaneSplash commented Jun 8, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

The purpose of this update is to allow one to add and monitor a device using a dynamic dns name, or an entry that you do not want to display as the default name. This option allows you to change the displayed name to match the sysName regardless of the DNS name.

@murrant

This comment has been minimized.

Member

murrant commented Jun 10, 2018

Would a always_use_sysname setting work? Or does that not cover your use case?

@InsaneSplash

This comment has been minimized.

Contributor

InsaneSplash commented Jun 12, 2018

I decided to split the options to implement in 2, so that the original option of IP to sysName could still be used on its own in case the user didn't want the sysName applied to their DynDNS host names etc. It just provides some flexibility. I guess one could also add the global option which could apply both rules?

@laf

laf approved these changes Jun 13, 2018

I'm fine with this change.

@laf laf added the WebUI label Jun 15, 2018

@InsaneSplash

This comment has been minimized.

Contributor

InsaneSplash commented Jun 19, 2018

ETA? :)

@murrant

This comment has been minimized.

Member

murrant commented Jun 19, 2018

@InsaneSplash. You want dns to be changed to sysname, but not IPs?

1 similar comment
@murrant

This comment has been minimized.

Member

murrant commented Jun 19, 2018

@InsaneSplash. You want dns to be changed to sysname, but not IPs?

@laf

This comment has been minimized.

Member

laf commented Jun 20, 2018

From the code and config names I'd say yes that's the correct scenario as we already have ip -> sysname so basically with both these, sysName will just always be used but allows flexibility for all scenarios

@laf laf merged commit ab5d17d into librenms:master Jun 23, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

@InsaneSplash InsaneSplash deleted the InsaneSplash:hostname_to_sysname branch Jul 24, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Sep 22, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.