New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to enable debug output with wrappers #8830

Merged
merged 4 commits into from Jun 20, 2018

Conversation

Projects
None yet
2 participants
@murrant
Member

murrant commented Jun 16, 2018

Now with optparse (python 2.3+)

Does not include your doc updates @laf

If I get some time later, I'll add them, feel free to as well.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

murrant added some commits Jun 8, 2018

Ability to enable debug output with wrappers
Output is redirected to a per-device file in the log directory.

@laf laf added this to the 1.41 milestone Jun 20, 2018

@laf

This comment has been minimized.

Member

laf commented Jun 20, 2018

Currently testing

@laf

laf approved these changes Jun 20, 2018

Tested disco, poller + servicer wrappers with and without -d. Tested ok.

@laf laf removed the Needs Testing label Jun 20, 2018

@laf laf merged commit a1aaafa into librenms:master Jun 20, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:wrapper-debug branch Jun 20, 2018

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

Added ability to enable debug output with wrappers (librenms#8830)
Now with optparse (python 2.3+)

Does not include your doc updates @laf 

If I get some time later, I'll add them, feel free to as well.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [ ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

@lock lock bot locked as resolved and limited conversation to collaborators Aug 19, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.