New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SNR Sensor to CMTS Arris #8840

Merged
merged 6 commits into from Jun 23, 2018

Conversation

Projects
None yet
2 participants
@TheGreatDoc
Contributor

TheGreatDoc commented Jun 22, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

TheGreatDoc added some commits Jun 22, 2018

@TheGreatDoc

This comment has been minimized.

Contributor

TheGreatDoc commented Jun 22, 2018

Hope I did correctly this time :-)

TheGreatDoc and others added some commits Jun 22, 2018

Update snr/cmts.inc.php
Removed last blank line
Update snr/cmts.inc.php
Removed last blank line and added space after comma in function

@laf laf added the Device 🖥 label Jun 23, 2018

@laf

This comment has been minimized.

Member

laf commented Jun 23, 2018

I've just pushed the json test file up, once tests complete we can merge.

@laf laf added this to the 1.41 milestone Jun 23, 2018

@laf

laf approved these changes Jun 23, 2018

LGTM

@laf laf merged commit 8c61032 into librenms:master Jun 23, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

Added SNR Sensor to CMTS Arris (librenms#8840)
DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X ] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

@TheGreatDoc TheGreatDoc deleted the TheGreatDoc:Arris_SNR branch Aug 5, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Oct 4, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.