Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revised Pushover title and severity level #8844

Merged
merged 1 commit into from Jun 26, 2018

Conversation

Projects
None yet
2 participants
@InsaneSplash
Copy link
Contributor

InsaneSplash commented Jun 26, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Revised the title of the message inline with the alert definition and revised the severity levels in accordance with the PushOver API. Removed some unused code.

@laf

laf approved these changes Jun 26, 2018

Copy link
Member

laf left a comment

LGTM

@laf laf added the Alerting 🔔 label Jun 26, 2018

@laf laf merged commit e2c698b into librenms:master Jun 26, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

mattie47 added a commit to mattie47/librenms that referenced this pull request Jul 2, 2018

Use alert rule title for Pushover title and severity level (librenms#…
…8844)

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [X] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

Revised the title of the message inline with the alert definition and revised the severity levels in accordance with the PushOver API. Removed some unused code.

@InsaneSplash InsaneSplash deleted the InsaneSplash:refine_pushover branch Jul 24, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Sep 22, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.