Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Smokeping.md #8860

Merged
merged 1 commit into from Jul 2, 2018

Conversation

Projects
None yet
2 participants
@mattie47
Copy link
Contributor

mattie47 commented Jul 2, 2018

I've rewritten the smokeping config docs after setting it up on a couple machines with LibreNMS.

Probably best to not do a diff, but just read the whole new proposed version. I've rewritten a lot of it, and tried to make the flow a lot better.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Update Smokeping.md
I've rewritten the smokeping config docs after setting it up on a couple machines with LibreNMS.

Probably best to not do a diff, but just read the whole new proposed version. I've rewritten a lot of it, and tried to make the flow a lot better.
@laf

laf approved these changes Jul 2, 2018

Copy link
Member

laf left a comment

LGTM

@laf laf merged commit 01fc664 into librenms:master Jul 2, 2018

3 checks passed

WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

gs-kamnas pushed a commit to gs-kamnas/librenms that referenced this pull request Aug 1, 2018

Update Smokeping documentation (librenms#8860)
I've rewritten the smokeping config docs after setting it up on a couple machines with LibreNMS.

Probably best to not do a diff, but just read the whole new proposed version. I've rewritten a lot of it, and tried to make the flow a lot better.

DO NOT DELETE THIS TEXT

#### Please note

> Please read this information carefully. You can run `./scripts/pre-commit.php` to check your code before submitting.

- [x] Have you followed our [code guidelines?](http://docs.librenms.org/Developing/Code-Guidelines/)

#### Testers

If you would like to test this pull request then please run: `./scripts/github-apply <pr_id>`, i.e `./scripts/github-apply 5926`

@lock lock bot locked as resolved and limited conversation to collaborators Aug 31, 2018

@mattie47 mattie47 deleted the mattie47:patch-4 branch Sep 17, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.