New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New transport modules (Kayako Classic, SMSFeedback) #9027

Merged
merged 15 commits into from Aug 21, 2018

Conversation

Projects
None yet
3 participants
@odvolk
Contributor

odvolk commented Aug 17, 2018

Hello! I've made a first version of Alert Transporting module for Kayako Classic Servicedesk. May be it is possible to use with Kayako OnPremise version (not sure).

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

odvolk added some commits Aug 17, 2018

Added Kayako Classic transport module. You need to enable RestAPI @ y…
…our Kayako service desk, provide needed data to transport module
@CLAassistant

This comment has been minimized.

Show comment
Hide comment
@CLAassistant

CLAassistant Aug 17, 2018

CLA assistant check
All committers have signed the CLA.

CLAassistant commented Aug 17, 2018

CLA assistant check
All committers have signed the CLA.

@laf

Thanks for submitting this.

Can you also add this to the docs as well please: https://github.com/librenms/librenms/blob/master/doc/Alerting/Transports.md

Show outdated Hide outdated LibreNMS/Alert/Transport/Kayako.php Outdated
Show outdated Hide outdated LibreNMS/Alert/Transport/Kayako.php Outdated
Show outdated Hide outdated LibreNMS/Alert/Transport/Kayako.php Outdated
Show outdated Hide outdated LibreNMS/Alert/Transport/Kayako.php Outdated

@laf laf added this to the 1.43 milestone Aug 17, 2018

@laf laf added the Alerting 🔔 label Aug 17, 2018

odvolk added some commits Aug 20, 2018

Changed function names in Kayako Classic transport module. Cleaned up…
… unused variables. Added checks for the success of sending alerts to Kayako Classic transport module
Show outdated Hide outdated LibreNMS/Alert/Transport/Kayako.php Outdated

odvolk added some commits Aug 20, 2018

@odvolk

This comment has been minimized.

Show comment
Hide comment
@odvolk

odvolk Aug 21, 2018

Contributor

@laf, hi! I wanted to know: I got an error of codeclimate, it says, that some parts of my module are needed for refactoring, but for now there is no need in this - the module is quite optimized, so how can i resolve it?

Contributor

odvolk commented Aug 21, 2018

@laf, hi! I wanted to know: I got an error of codeclimate, it says, that some parts of my module are needed for refactoring, but for now there is no need in this - the module is quite optimized, so how can i resolve it?

@odvolk

This comment has been minimized.

Show comment
Hide comment
@odvolk

odvolk Aug 21, 2018

Contributor

Added another one module for transporting, called SMSFeedback

Contributor

odvolk commented Aug 21, 2018

Added another one module for transporting, called SMSFeedback

@odvolk odvolk changed the title from New transport module (Kayako Classic) to New transport modules (Kayako Classic, SMSFeedback) Aug 21, 2018

@laf

laf approved these changes Aug 21, 2018

LGTM

No real need to have the function options different than other modules but not a blocker.

Ideally going forward if you add support for anything else, please branch off from master and add one feature per branch rather than bundling in to one.

@laf laf merged commit e448190 into librenms:master Aug 21, 2018

3 of 4 checks passed

codeclimate 8 issues to fix
Details
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf referenced this pull request Aug 22, 2018

Closed

Fixed router.db generation script for rancid 3.1+ #9056

1 of 1 task complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment