New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check for incorrect heartbeats in rrdtstep.php script #9041

Merged
merged 1 commit into from Aug 21, 2018

Conversation

Projects
None yet
2 participants
@murrant
Member

murrant commented Aug 20, 2018

Also, fix some incorrect config names (rrd_step -> rrd.step)

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

Check for incorrect heartbeats in rrdtstep.php script
Also, fix some incorrect config names (rrd_step -> rrd.step)

@murrant murrant added the Enhancement label Aug 20, 2018

@laf

laf approved these changes Aug 21, 2018

LGTM

@laf laf added the Refactor label Aug 21, 2018

@laf laf merged commit d83b675 into librenms:master Aug 21, 2018

3 of 4 checks passed

codeclimate 5 issues to fix
Details
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:rrdstep-heartbeat-check branch Aug 21, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Oct 20, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.