New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Teleste Luminato #9061

Merged
merged 43 commits into from Oct 1, 2018

Conversation

Projects
None yet
4 participants
@jozefrebjak
Contributor

jozefrebjak commented Aug 23, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

jozefrebjak added some commits Aug 23, 2018

@TheGreatDoc

This comment has been minimized.

Show comment
Hide comment
@TheGreatDoc

TheGreatDoc Aug 23, 2018

Contributor

@jozefrebjak Check the travis CI. Seems like you uploaded a bitmap as svg.

Contributor

TheGreatDoc commented Aug 23, 2018

@jozefrebjak Check the travis CI. Seems like you uploaded a bitmap as svg.

jozefrebjak added some commits Aug 24, 2018

Show outdated Hide outdated includes/polling/os/teleste.inc.php Outdated
Show outdated Hide outdated mibs/HOST-RESOURCES-MIB.mib Outdated
Show outdated Hide outdated includes/definitions/teleste.yaml Outdated

@laf laf added this to the 1.44 milestone Aug 27, 2018

jozefrebjak added some commits Aug 27, 2018

jozefrebjak added some commits Sep 16, 2018

@jozefrebjak jozefrebjak changed the title from Added Initial detection for Teleste Luminato to WIP Added Initial detection for Teleste Luminato Sep 16, 2018

jozefrebjak added some commits Sep 17, 2018

@jozefrebjak jozefrebjak changed the title from WIP Added Initial detection for Teleste Luminato to Added Initial detection for Teleste Luminato Sep 18, 2018

@jozefrebjak jozefrebjak changed the title from Added Initial detection for Teleste Luminato to Added support for Teleste Luminato Sep 18, 2018

@laf

One change, the rest looks good.

Show outdated Hide outdated includes/polling/os/luminato.inc.php Outdated

@laf laf removed the Needs Tests 🦄 label Sep 19, 2018

jozefrebjak and others added some commits Sep 19, 2018

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf Sep 19, 2018

Member

I've sorted out the tests so that should be fine. However the two mibs you've added reference another, TELESTE-ROOT-MIB, do you have this to upload to this pr please?

Member

laf commented Sep 19, 2018

I've sorted out the tests so that should be fine. However the two mibs you've added reference another, TELESTE-ROOT-MIB, do you have this to upload to this pr please?

jozefrebjak and others added some commits Sep 20, 2018

@murrant

LGTM

Stale review

@murrant murrant merged commit 56481c6 into librenms:master Oct 1, 2018

4 checks passed

WIP ready for review
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment