Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Fixed url to graphs from date selector #9109
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
Aug 30, 2018
This has functionally fixed the 404 issue I was hitting. The only thing that's a bit strange is that following the base URL, the tail part of the URL is prepended with a /
Thus the URL gets composed like: http://hostname.domain/librenms//graphs/to=1535662200/id=1800/type=port_bits/from=1535658600/
In my config I have the base URL configured as /librenms/ Removing the trailing / from the base URL breaks just about everything. Perhaps the // is the result of what the Nginx reverse proxy is doing with the URL.
No. Despite the // in the URL the page loads fine. Geoffrey Wolf Senior Network Engineer intermedix, an R1 Company Office: 412.450.6137 Geoffrey.Wolf@intermedix.com<mailto:%0dGeoffrey.Wolf@intermedix.com> | www.intermedix.com<http://www.intermedix.com/> The information contained in this message is confidential and may be privileged and/or protected under law. If you received this message in error, please notify us immediately by forwarding a copy to firstname.lastname@example.org<mailto:email@example.com> and delete the original message and any attachments. From: Neil Lathwood <firstname.lastname@example.org> Sent: Thursday, August 30, 2018 5:42 PM To: librenms/librenms <email@example.com> Cc: Geoffrey Wolf <Geoffrey.Wolf@intermedix.com>; Comment <firstname.lastname@example.org> Subject: Re: [librenms/librenms] Fixed url to graphs from date selector (#9109) I assume it's not causing you an issue? — You are receiving this because you commented. Reply to this email directly, view it on GitHub<#9109 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AZiPT6NLu9TOf2KkUuFQpXHKKYeevS5yks5uWFwcgaJpZM4WSX-s>. The information contained in this message is confidential and may be privileged and/or protected under law. If you receive this message in error, please notify us immediately by forwarding a copy to email@example.com and delete the original message and any attachments.