New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore dns errors when fetching astext #9180

Merged
merged 1 commit into from Sep 12, 2018

Conversation

Projects
None yet
2 participants
@murrant
Member

murrant commented Sep 11, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926

@murrant murrant added the Bug 🐞 label Sep 11, 2018

@TheGreatDoc

LGTM

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Sep 12, 2018

Member

@TheGreatDoc you could merge this :)

Member

murrant commented Sep 12, 2018

@TheGreatDoc you could merge this :)

@TheGreatDoc TheGreatDoc merged commit 31e931d into librenms:master Sep 12, 2018

4 checks passed

WIP ready for review
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details
@TheGreatDoc

This comment has been minimized.

Show comment
Hide comment
@TheGreatDoc

TheGreatDoc Sep 12, 2018

Contributor

Merged #9180 into master

Contributor

TheGreatDoc commented Sep 12, 2018

Merged #9180 into master

@murrant murrant deleted the murrant:astext-dns branch Sep 12, 2018

@murrant

This comment has been minimized.

Show comment
Hide comment
@murrant

murrant Sep 12, 2018

Member

@TheGreatDoc congrats on your first merge :)

Member

murrant commented Sep 12, 2018

@TheGreatDoc congrats on your first merge :)

@TheGreatDoc

This comment has been minimized.

Show comment
Hide comment
@TheGreatDoc

TheGreatDoc Sep 12, 2018

Contributor

@murrant Thanks! Very exciting :D

Contributor

TheGreatDoc commented Sep 12, 2018

@murrant Thanks! Very exciting :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment