New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow zoom to be decimal and switch zoomSnap to 0.1 #9259

Merged
merged 1 commit into from Oct 6, 2018

Conversation

Projects
None yet
2 participants
@cchance27
Contributor

cchance27 commented Sep 24, 2018

Allow 1 decimal place for initial zoom and lower zoom snap interval to improve initial zoom in widgets.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Allow zoom to be decimal and switch zoomSnap off
Allow 1 decimal place for initial zoom and lower zoom snap interval to improve initial zoom in widgets.
@cchance27

This comment has been minimized.

Contributor

cchance27 commented Sep 24, 2018

not going to lie here i wanted to add this as an adjustable value in the widget settings and default settings via config, but got super confused with the widget settings not working, and then after some testing on my side i couldn't find a reason not to just set the default zoomSnap to 0.1 and change the sprintf to allow 1 decimal place.

This allows a bit nicer/more precise initial zooming (especially on widgets)

@laf

laf approved these changes Oct 6, 2018

LGTM

@laf laf merged commit dd39a1a into librenms:master Oct 6, 2018

4 checks passed

WIP ready for review
Details
codeclimate All good!
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf added the WebUI label Oct 6, 2018

@cchance27 cchance27 deleted the cchance27:zoomsnap branch Oct 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment