New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check file permissions on every request, handle failures #9264

Merged
merged 10 commits into from Oct 19, 2018

Conversation

Projects
None yet
2 participants
@murrant
Member

murrant commented Sep 26, 2018

Improve error page visually
May not catch all errors yet, if we find more we can easily add them.
I'm not sure if rrd is strictly needed here, but threw it in for good measure. Let me know if I'm wrong.

image

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added the WebUI label Sep 26, 2018

@laf

laf approved these changes Oct 6, 2018

LGTM and tested ok.

I have pushed a small change to User validation as \n doesn't show in the Webui for validation. Realise we could probably do nl2br() for webui output but this seemed to make sense.

@laf laf added this to the 1.44 milestone Oct 6, 2018

@murrant

This comment has been minimized.

Member

murrant commented Oct 12, 2018

Hmm, I think it is supposed to be an array for proper formatting.

@laf

LGTM + Tested

@murrant murrant modified the milestones: 1.44, 1.45 Oct 15, 2018

@murrant murrant merged commit 607a567 into librenms:master Oct 19, 2018

2 of 3 checks passed

codeclimate 6 issues to fix
Details
WIP ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fancy-errors branch Oct 19, 2018

@murrant

This comment has been minimized.

Member

murrant commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment