New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow login with GET variables #9268

Merged
merged 1 commit into from Oct 2, 2018

Conversation

Projects
None yet
2 participants
@murrant
Member

murrant commented Sep 27, 2018

I'm not sure this is needed since enabling remember me will keep the user logged in until log out. Thoughts?

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant added the WebUI label Sep 27, 2018

@tomarch

This comment has been minimized.

Show comment
Hide comment
@tomarch

tomarch Sep 27, 2018

Contributor

Thanks for this PR. It's work fine for me.
I need this feature for dynamic display.

Contributor

tomarch commented Sep 27, 2018

Thanks for this PR. It's work fine for me.
I need this feature for dynamic display.

@murrant murrant added this to the 1.44 milestone Oct 1, 2018

@murrant murrant merged commit 9a17307 into librenms:master Oct 2, 2018

3 of 4 checks passed

codeclimate 3 issues to fix
Details
WIP ready for review
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:get-login branch Oct 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment