New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to escape services commands properly. #9269

Merged
merged 3 commits into from Oct 17, 2018

Conversation

Projects
None yet
2 participants
@murrant
Member

murrant commented Sep 27, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@laf

This comment has been minimized.

Member

laf commented Oct 6, 2018

Seems to fix: #8218

Also fixes: #4891

@laf laf added this to the 1.45 milestone Oct 6, 2018

@laf

laf approved these changes Oct 6, 2018

LGTM. Tested ok as well

@laf laf merged commit 10432b1 into librenms:master Oct 17, 2018

3 checks passed

WIP ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:services-shell-escape branch Oct 17, 2018

@murrant

This comment has been minimized.

Member

murrant commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment