New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated DataDomain MIB, Added DataDomain Storage poller and discovery #9270

Merged
merged 7 commits into from Oct 17, 2018

Conversation

Projects
None yet
4 participants
@acl
Contributor

acl commented Sep 27, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@CLAassistant

This comment has been minimized.

CLAassistant commented Sep 27, 2018

CLA assistant check
All committers have signed the CLA.

acl added some commits Oct 3, 2018

@laf

Thanks for adding this support.

Can you please add test data as well: https://docs.librenms.org/#Developing/os/Test-Units/#example-workflow

* @author Abel Laura <abel.laura@gmail.com>
*/
if ($device['os'] == 'datadomain') {

This comment has been minimized.

@laf

laf Oct 6, 2018

Member

You can remove this, shouldn't be needed.

This comment has been minimized.

@acl

acl Oct 8, 2018

Contributor

I'll take of that today. Thanks.

@laf laf added this to the 1.45 milestone Oct 6, 2018

acl and others added some commits Oct 8, 2018

@laf laf removed the Needs Tests 🦄 label Oct 9, 2018

@laf

laf approved these changes Oct 9, 2018

LGTM

@laf laf merged commit e912008 into librenms:master Oct 17, 2018

3 checks passed

WIP ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Member

murrant commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment