Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cyberpower extra sensor values #9278

Merged
merged 4 commits into from Oct 17, 2018

Conversation

Projects
None yet
5 participants
@takenalias
Copy link
Contributor

takenalias commented Oct 2, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

takenalias added some commits Oct 2, 2018

Update to add support for environment sensor
Adding support for RM203 card environment sensor, temp and humidity.
@CLAassistant

This comment has been minimized.

Copy link

CLAassistant commented Oct 2, 2018

CLA assistant check
All committers have signed the CLA.

@laf
Copy link
Member

laf left a comment

@takenalias

This comment has been minimized.

Copy link
Contributor Author

takenalias commented Oct 3, 2018

@takenalias

This comment has been minimized.

Copy link
Contributor Author

takenalias commented Oct 9, 2018

Not sure how to generate a new JSON file, but I have uploaded the snmprec.

@laf

laf approved these changes Oct 9, 2018

@laf laf removed the Needs Tests 🦄 label Oct 9, 2018

@laf laf added this to the 1.45 milestone Oct 9, 2018

@07stuntar1

This comment has been minimized.

Copy link

07stuntar1 commented Oct 12, 2018

Has this been merged into the daily update builds or do i need to do something special?

@takenalias

This comment has been minimized.

Copy link
Contributor Author

takenalias commented Oct 12, 2018

Has this been merged into the daily update builds or do i need to do something special?

I think it will be merged into the 1.45 release later this month.

@laf laf merged commit f8f1540 into librenms:master Oct 17, 2018

3 checks passed

WIP ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
@07stuntar1

This comment has been minimized.

Copy link

07stuntar1 commented Oct 17, 2018

Sweet working good!

@takenalias

This comment has been minimized.

Copy link
Contributor Author

takenalias commented Oct 18, 2018

Awsome. Glad to hear.

@07stuntar1

This comment has been minimized.

Copy link

07stuntar1 commented Oct 18, 2018

Thank you

@takenalias

This comment has been minimized.

Copy link
Contributor Author

takenalias commented Oct 18, 2018

I just realised there will be an issue with humidity, I had a divisor on humidity. This should not have been the case. Not sure the best way to get it sorted. Apologies.

@laf

This comment has been minimized.

Copy link
Member

laf commented Oct 18, 2018

@takenalias Just submit another pull request to change it.

@takenalias takenalias deleted the takenalias:patch-1 branch Oct 19, 2018

@murrant

This comment has been minimized.

Copy link
Member

murrant commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.