New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved support for Racom Ray radios #9279

Merged
merged 14 commits into from Oct 22, 2018

Conversation

Projects
None yet
3 participants
@jozefrebjak
Contributor

jozefrebjak commented Oct 2, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

jozefrebjak added some commits Oct 2, 2018

update os polling for ray
I changed hardware detection, because in old format i got a hostname instead of hardware. I added features tab also.
Added wireless rate sensors
I added sensors for Netbitrate and Maxbirate
@laf

Thanks for this. Can you add test data for this new sensor please:

https://docs.librenms.org/#Developing/os/Test-Units/#example-workflow

Can you not get an svg logo for use? Putting a bigger png makes no difference as they are forced to 32x32 in the device list.

jozefrebjak added some commits Oct 10, 2018

@jozefrebjak

This comment has been minimized.

Contributor

jozefrebjak commented Oct 11, 2018

So I added svg logo for this vendor and test. I believe that this is ready to merge. I will try to add more sensors for this device but in another pull request, because I need to test sensors more complexly.

@laf laf removed the Needs Tests 🦄 label Oct 13, 2018

@laf laf added this to the 1.45 milestone Oct 13, 2018

@murrant murrant merged commit d111bd9 into librenms:master Oct 22, 2018

2 of 3 checks passed

codeclimate 6 issues to fix
Details
WIP ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Member

murrant commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment