New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for LLDP on ALCATEL/NOKIA SR OS #9298

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@vitalisator
Contributor

vitalisator commented Oct 4, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@laf

Thanks for adding this support.

Can you please also add test data: https://docs.librenms.org/#Developing/os/Test-Units/#example-workflow

@laf laf added this to the 1.45 milestone Oct 6, 2018

@laf

laf approved these changes Oct 12, 2018

LGTM

@laf laf merged commit fcadd3c into librenms:master Oct 17, 2018

2 of 3 checks passed

codeclimate 1 issue to fix
Details
WIP ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf removed the Needs Tests 🦄 label Oct 17, 2018

@murrant

This comment has been minimized.

Member

murrant commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment