Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if array exists for new alert rules and create if not #9303

Merged
merged 1 commit into from Oct 6, 2018

Conversation

Projects
None yet
2 participants
@laf
Copy link
Member

commented Oct 5, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Fixes: https://community.librenms.org/t/i-can-t-add-alert-rules-from-the-collection-webgui/5737

@laf laf added Bug 🐞 WebUI labels Oct 5, 2018

@murrant

murrant approved these changes Oct 5, 2018

Copy link
Member

left a comment

LGTM

@laf laf merged commit d1772ea into librenms:master Oct 6, 2018

3 checks passed

WIP ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:bug/community-5737 branch Oct 6, 2018

@lock lock bot locked as resolved and limited conversation to collaborators Dec 5, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.