New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't force root url #9308

merged 1 commit into from Oct 8, 2018


None yet
3 participants

murrant commented Oct 8, 2018

Does more harm than good. Need to find a more robust solution for proxy + subdirectory -> non-subdirectory.


Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.


If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Don't force root url
Does more harm than good.

@murrant murrant added this to the 1.44 milestone Oct 8, 2018

@murrant murrant added the WebUI label Oct 8, 2018


laf approved these changes Oct 8, 2018


@laf laf merged commit df90881 into librenms:master Oct 8, 2018

3 checks passed

WIP ready for review
codeclimate 1 fixed issue
license/cla Contributor License Agreement is signed.

@laf laf deleted the murrant:dont_force_root branch Oct 8, 2018


This comment has been minimized.

jeskko commented Oct 24, 2018

This change broke reverse proxy + subdirectory support for me completely, works again mostly fine by reverting the change.


This comment has been minimized.


murrant commented Oct 25, 2018

@Jekko this breaks normal subdir installs.


This comment has been minimized.

jeskko commented Oct 25, 2018

Nice. 👍
I hope that there's a workaround coming that works for the both cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment