New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mapquest API Geocode support #9316

Merged
merged 2 commits into from Oct 22, 2018

Conversation

Projects
None yet
4 participants
@brianatlarge
Contributor

brianatlarge commented Oct 11, 2018

Since the Google API for geocoding requires billing to be activated, I added support to use the Mapquest geocoding API which currently offers a free tier.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Add Mapquest API Geocode support
Since the Google API for geocoding is no longer free, I added support to use the Mapquest geocoding API which currently offers a free tier.
@CLAassistant

This comment has been minimized.

CLAassistant commented Oct 11, 2018

CLA assistant check
All committers have signed the CLA.

@laf

Would you mind adding some docs to detail the use of both of these engines.

At present the only doc is https://docs.librenms.org/#Extensions/World-Map/#world-map-configuration but we could do with one under 3rd Party Integration. Maybe called 'Geo Location'

@laf laf added the Feature label Oct 13, 2018

@brianatlarge

This comment has been minimized.

Contributor

brianatlarge commented Oct 15, 2018

Documentation update requested:
#9324 (comment)

@laf

This comment has been minimized.

Member

laf commented Oct 15, 2018

Documentation update requested:
#9324 (comment)

You can update additional files here, you don't need to do another pull request. Just edit what you want changing in the branch patch-1.

However that other PR is changing docs unrelated to this.

@brianatlarge

This comment has been minimized.

Contributor

brianatlarge commented Oct 16, 2018

Documentation update requested:
#9324 (comment)

You can update additional files here, you don't need to do another pull request. Just edit what you want changing in the branch patch-1.

However that other PR is changing docs unrelated to this.

Corrected with this pull request.
#9330

@brianatlarge brianatlarge referenced this pull request Oct 16, 2018

Merged

Added geocode engine configuration information #9330

1 of 1 task complete
@laf

laf approved these changes Oct 17, 2018

LGTM

@murrant murrant merged commit 74d4a7c into librenms:master Oct 22, 2018

2 of 3 checks passed

codeclimate 2 issues to fix
Details
WIP ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Member

murrant commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment