New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to make proxy sub-dir -> app no subdir work #9317

Merged
merged 1 commit into from Oct 17, 2018

Conversation

Projects
None yet
2 participants
@murrant
Member

murrant commented Oct 11, 2018

Set APP_URL and APP_URL_SUFFIX in .env

Not sure if this is the correct fix. A proxy with a subdirectory redirecting to the app that isn't using a subdirectory is particularly difficult and has a chance to break normal users.

Need all configurations to test this, not just the type it is trying to fix.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Attempt to make proxy sub-dir -> app no subdir work
Set APP_URL and APP_URL_SUFFIX in .env
@laf

laf approved these changes Oct 13, 2018

I don't run sub-dir but this works fine without.

Feel free to merge.

@laf laf removed the Needs Testing label Oct 17, 2018

@laf laf merged commit df850a3 into librenms:master Oct 17, 2018

2 of 3 checks passed

codeclimate 2 issues to fix
Details
WIP ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:subdir-proxy branch Oct 17, 2018

murrant added a commit that referenced this pull request Oct 18, 2018

@murrant murrant restored the murrant:subdir-proxy branch Oct 18, 2018

murrant added a commit that referenced this pull request Oct 18, 2018

Revert "Attempt to make proxy sub-dir -> app no subdir work" (#9341)
* Revert "Attempt to make proxy sub-dir -> app no subdir work (#9317)"

This reverts commit df850a3.
@murrant

This comment has been minimized.

Member

murrant commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment