New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow alerting on tables with relative/indirect glues. #932

Merged
merged 3 commits into from May 7, 2015

Conversation

Projects
None yet
2 participants
@f0o
Member

f0o commented May 7, 2015

This commit introduces a lookup using an adaption of left/right expansion searches to find a missing glue-column across several layers of relations.
You can now alert on data having a glue mapped to other entities as long as it resolves to 'device_id' in under 30 cycles.
First intention of usage is to alert on bill-usages.
The bills-table does not contain a valid 'device_id' glue and has to be resolved via 'bills.bill_id -> bill_ports.port_id -> ports.device_id'.
This example consumes 3+1 cycles.

NOTE: This PR is considered as a fairly big update to the way rules are interpreted. Please test thoroughly and in-depth (yes I know this is redundant but really now ;)

Related: #931

Allow alerting on tables with relative/indirect glues.
This commit introduces a lookup using an adaption of left/right expansion searches to find a missing glue-column across several layers of relations.
You can now alert on data having a glue mapped to other entities as long as it resolves to 'device_id' in under 30 cycles.
First intention of usage is to alert on bill-usages.
The bills-table does not contain a valid 'device_id' glue and has to be resolved via 'bills.bill_id -> bill_ports.port_id -> ports.device_id'.
This example consumes 3+1 cycles.

@laf laf self-assigned this May 7, 2015

@laf laf added the Enhancement label May 7, 2015

f0o added some commits May 7, 2015

laf added a commit that referenced this pull request May 7, 2015

Merge pull request #932 from f0o/issue-931
Allow alerting on tables with relative/indirect glues.

@laf laf merged commit 48ea557 into librenms:master May 7, 2015

1 check passed

Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment