Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to use new theme for docs site #9320

Merged
merged 15 commits into from Oct 27, 2018

Conversation

Projects
None yet
3 participants
@laf
Copy link
Member

commented Oct 12, 2018

Test site: http://web01.lathwood.uk:8443/

If this is good for a merge then don't, it may not deploy the site correctly so I'd like to merge it in and test / fix on the fly if needs be.

@Rosiak

This comment has been minimized.

Copy link
Member

commented Oct 17, 2018

I'm cool with this, wish the load time will be the same as your test site ;-)

@laf

This comment has been minimized.

Copy link
Member Author

commented Oct 17, 2018

I'm cool with this, wish the load time will be the same as your test site ;-)

It should / will with this new template.

@murrant

This comment has been minimized.

Copy link
Member

commented Oct 25, 2018

@laf I modified this to just use the base material theme.
Probably should restrict the theme version to be safe.


if [ "$EXECUTE_BUILD_DOCS" != "true" ]; then
echo "Doc build skipped"
exit 0
fi

pip install --user 'jinja2<2.9' mkdocs pymdown-extensions
pip install --user mkdocs mkdocs-material pymdown-extensions

This comment has been minimized.

Copy link
@laf

laf Oct 26, 2018

Author Member

mkdocs-material by default needs mkdocs 1.x, mkdocs that's currently being installed in travis is 0.17.5 so I'm not sure this is going to work

laf added some commits Oct 26, 2018

laf added some commits Oct 27, 2018

@laf laf merged commit 1ee2e8e into librenms:master Oct 27, 2018

5 of 6 checks passed

codeclimate 1 issue to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:updated-docs-theme branch Oct 27, 2018

@murrant

This comment has been minimized.

Copy link
Member

commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.