New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct ID for incident resolution #9321

Merged
merged 2 commits into from Oct 16, 2018

Conversation

Projects
None yet
2 participants
@laf
Member

laf commented Oct 12, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

https://community.librenms.org/t/major-bug-in-the-recent-releases-pager-duty/5634/2

@murrant

This comment has been minimized.

Member

murrant commented Oct 15, 2018

I thought this was supposed to be the id in the alert_log table so we we don't repeat ids for events.

@laf

This comment has been minimized.

Member

laf commented Oct 15, 2018

It's supposed to be a static ID throughout the life of the alert otherwise PD can't match the recovery alert.

I've tested before and after this fix and with this on new transports it marks the alert as resolved. I haven't tested with the old transports but it should be the same.

@laf laf added this to the 1.44 milestone Oct 15, 2018

@murrant murrant merged commit 3fc9e33 into librenms:master Oct 16, 2018

3 checks passed

WIP ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:community-5634 branch Oct 17, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment