New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webui : Oxidized rights enforcement #9331

Merged
merged 2 commits into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@PipoCanaja
Contributor

PipoCanaja commented Oct 16, 2018

This patch allow checking the rights for a device (and will not display it if the user cannot see it).

It does also give an explanation on devices that appear in the list (because they exist in Oxidized) but cannot be clicked (because they do not exist in LibreNMS).

capture

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

PipoCanaja added some commits Oct 16, 2018

webui: display only devices that the user is allowed to view in oxidi…
…zed node list, and explain why some devices known in oxidized are not displayed because unknown in LibreNMS
webui: display only devices that the user is allowed to view in oxidi…
…zed node list, and explain why some devices known in oxidized are not displayed because unknown in LibreNMS (CodeClimate)
@laf

laf approved these changes Oct 16, 2018

LGTM

@laf laf added the WebUI label Oct 16, 2018

@laf laf added this to the 1.45 milestone Oct 16, 2018

@laf laf merged commit 417e518 into librenms:master Oct 17, 2018

2 of 3 checks passed

codeclimate 2 issues to fix
Details
WIP ready for review
Details
license/cla Contributor License Agreement is signed.
Details

murrant added a commit that referenced this pull request Oct 18, 2018

@murrant

This comment has been minimized.

Member

murrant commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment