New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F5 APM current sessions graphing #9334

Merged
merged 4 commits into from Oct 17, 2018

Conversation

Projects
None yet
3 participants
@JohnSPeach
Contributor

JohnSPeach commented Oct 17, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

While this creates the graphs under Apm for the F5s, there is no data. I can pull the data manually. Maybe I have the definition incorrect in includes/polling/os/f5.inc.php?

snmpget -m /opt/librenms/mibs/f5/F5-BIGIP-APM-MIB -v 3 -u -l authPriv -a SHA -A -x AES -X apmAccessStatCurrentActiveSessions.0
F5-BIGIP-APM-MIB::apmAccessStatCurrentActiveSessions.0 = Wrong Type (should be Counter64): Gauge32: 1245

or maybe it's because the OID has the incorrect type in it, although the result is actually correct.

JohnSPeach added some commits Oct 17, 2018

Update definitions.inc.php
Added F5 APM graph type
Update f5.inc.php
Add current APM sessions graph
Create bigip_apm_curr_sessions.inc.php
Graph F5 APM current sessions
Create 269.sql
Add F5 APM current sessions
@JohnSPeach

This comment has been minimized.

Contributor

JohnSPeach commented Oct 17, 2018

The data is being collected - If I click on one of the graphs and then select Bigip_apm_curr_sessions from the dropdown in the upper right, I have the graph. What am I missing from setup for having them on the main page?

@laf

laf approved these changes Oct 17, 2018

LGTM

@laf laf added the Device 🖥 label Oct 17, 2018

@laf laf merged commit 001d7d7 into librenms:master Oct 17, 2018

3 checks passed

WIP ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

murrant added a commit that referenced this pull request Oct 18, 2018

@murrant

This comment has been minimized.

Member

murrant commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment