Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
New User Management #9348
DO NOT DELETE THIS TEXT
If you would like to test this pull request then please run:
Does not collide with #9313, utilizes edituser still to manage device permissions.
Doesn't save when unselecting Can Modify Password.
I'm not a fan of the new user / edit user form - it looked better as it was when it was a bit more condensed and concise, just seems to be trying to take up the entire page for the sake of it now.
The old edit user / add user pages still exist.
Does anything need to be done with
Could you make it so that deleting a user doesn't refresh the page and just removes the row. We do this in the alert-rules if you want a code example to look at.
Aside from that, all other options adding / deleting saving / updating works for me.
Looks better now :)
So just the not being able to unselect Allow user to change password option. You can enable it and it saves but not disable it.
I realise the old edituser page needs to stay as the perms are done through it but I think it would be good to redirect the standard access or /edituser/ to this new page + change the link for
Same question about it affecting
2 times, most recently
Mar 18, 2019
Apr 23, 2019
Nice I like this view
Just noting two minor issues on my instance, unfortunately i have no dev environment setup yet to test any fixes
1 - LibreNMS logo changes, i have dark mode set, so every other page pulls (https://LIBRENMS/images/librenms_logo_dark.svg), but on manage users it pulls a different logo (https://LIBRENMS/images/librenms_logo_light.svg)
2 - The custom menu doesn't work for anything under https://LIBRENMS/users , i'm not sure but i wonder if LegacyAuth::get()->canManageUsers() blocks it
Ahh thanks, 2. is rather indispensable for me, hopefully for others too as currently the only way to share custom aggregations e.g https://librenms/iftype/type=customportdescription/ and other links which don't fall under any other menu.
Thanks for fixing my other code too! I wasn't sure if LegacyAuth was still a thing :)
Ahh i remember now exploring custom_descr a year ago, i forgot it automatically adds to the menu.
I think the reason was we have around 20 different aggregations, so putting a little symbol next to it (Font Awesome icons) and naming the aggregation(s) (like Total Internet Traffic) which is a combination of different aggregators made it a bit more user friendly for the rest of the users so i put it in the custom menu.
I do use it for portal links to other applications like an ip manager, and to my weather animation (https://community.librenms.org/t/weathermap-histogram/1052/4?u=chas) but i suppose this could live somewhere else.
But good point i could switch back to the custom_descr in config.php if the new menu system is not supporting it