Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 64bits memory pools on CISCO-ENHANCED-MEMPOOL-MIB #9353

Merged
merged 4 commits into from Oct 23, 2018

Conversation

Projects
None yet
3 participants
@alangregory
Copy link
Contributor

alangregory commented Oct 19, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@laf
Copy link
Member

laf left a comment

Can you add some test data for this as well please?

https://docs.librenms.org/#Developing/os/Test-Units/#example-workflow

$oids = array(
"cempMemPoolUsed.$oid",
"cempMemPoolFree.$oid",
"cempMemPoolLargestFree.$oid",
);
$data = snmp_get_multi_oid($device, $oids, '-OUQ', 'CISCO-ENHANCED-MEMPOOL-MIB');
$HCdata = snmp_get_multi_oid($device, $HCoids, '-OUQ', 'CISCO-ENHANCED-MEMPOOL-MIB');

This comment has been minimized.

Copy link
@laf

laf Oct 19, 2018

Member

You could probably just use $data here then change the if check to be inverse.

Alan Gregory added some commits Oct 22, 2018

@laf

laf approved these changes Oct 22, 2018

Copy link
Member

laf left a comment

LGTM

@laf laf removed the Needs Tests 🦄 label Oct 22, 2018

@laf laf added this to the 1.45 milestone Oct 22, 2018

@murrant murrant merged commit d0b923f into librenms:master Oct 23, 2018

3 checks passed

WIP ready for review
Details
codeclimate 2 fixed issues
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Copy link
Member

murrant commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.