New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg the alert settings page to show what options are deprecated #9354

Merged
merged 3 commits into from Oct 21, 2018

Conversation

Projects
None yet
3 participants
@laf
Member

laf commented Oct 19, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

image

@laf laf added the WebUI label Oct 19, 2018

@laf laf added this to the 1.45 milestone Oct 20, 2018

echo generate_dynamic_config_panel('Email options', $config_groups, $mail_conf, 'mail');
echo '<br /><div class="well"><strong class="text-danger">DEPRECATED</strong>: All options below are deprecated, please use the new Alert Transports section under Alerts to configure transports - <a href="https://docs.librenms.org/Alerting/Transports/" target="_blank">docs</a>.</div>';

This comment has been minimized.

@TheGreatDoc

TheGreatDoc Oct 21, 2018

Contributor

To make it like other places, what if changing to:

echo '<br /><div class="well"><strong class="text-danger">DEPRECATED</strong>: All options below are deprecated, please use the new Alert Transports section under Alerts to configure transports :: <a href="https://docs.librenms.org/Alerting/Transports/" target="_blank">Docs <i class="fa fa-book fa-1x"></i></a></div>';

@TheGreatDoc

LGTM

@TheGreatDoc TheGreatDoc merged commit f8ec6c5 into librenms:master Oct 21, 2018

3 checks passed

WIP ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the laf:alert-settings-reorg branch Oct 21, 2018

@murrant

This comment has been minimized.

Member

murrant commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment