New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show device "features" in correct column #9366

Merged
merged 2 commits into from Oct 25, 2018

Conversation

Projects
None yet
4 participants
@Jellyfrog
Contributor

Jellyfrog commented Oct 22, 2018

Align the device overview with the device specific overview.

Before:
image

After:
image

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Show resolved Hide resolved html/includes/table/devices.inc.php Outdated

@laf laf added the WebUI label Oct 22, 2018

@CLAassistant

This comment has been minimized.

CLAassistant commented Oct 22, 2018

CLA assistant check
All committers have signed the CLA.

@murrant

This comment has been minimized.

Member

murrant commented Oct 23, 2018

Why is this the correct column? I think there is confusion in the code base what "features" actually is. Some treat it as hardware features some as software features.

@Jellyfrog

This comment has been minimized.

Contributor

Jellyfrog commented Oct 23, 2018

Why is this the correct column? I think there is confusion in the code base what "features" actually is. Some treat it as hardware features some as software features.

It aligns it with how it is in the device overview and the device "overlib"

@murrant

This comment has been minimized.

Member

murrant commented Oct 23, 2018

Good point. My guess is it was done this way originally to shorten the Operating System column and use unused space in the platform column.

@laf

laf approved these changes Oct 23, 2018

LGTM

@laf laf added this to the 1.45 milestone Oct 23, 2018

@Jellyfrog

This comment has been minimized.

Contributor

Jellyfrog commented Oct 24, 2018

Good point. My guess is it was done this way originally to shorten the Operating System column and use unused space in the platform column.

That was my guess too, think we should keep it uniformed tho, it's a bit confusing now.

@murrant murrant merged commit a31f477 into librenms:master Oct 25, 2018

2 checks passed

codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Member

murrant commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment