Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize images #9369

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
3 participants
@Jellyfrog
Copy link
Contributor

Jellyfrog commented Oct 22, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@laf
Copy link
Member

laf left a comment

LGTM.

Some of these may get overwritten as they are from libraries we use. Just an FYI more than anything.

@laf laf added the WebUI label Oct 22, 2018

@laf laf added this to the 1.45 milestone Oct 22, 2018

@Jellyfrog Jellyfrog force-pushed the Jellyfrog:feature/optimize-images branch from 57040bc to f104e91 Oct 23, 2018

@Jellyfrog Jellyfrog force-pushed the Jellyfrog:feature/optimize-images branch from f104e91 to 1a34a88 Oct 23, 2018

@laf laf merged commit ef13cd2 into librenms:master Oct 23, 2018

3 checks passed

WIP ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Copy link
Member

murrant commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.