Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow F5 APM graphs to display automatically #9377

Merged
merged 3 commits into from Oct 25, 2018

Conversation

Projects
None yet
2 participants
@JohnSPeach
Copy link
Contributor

commented Oct 24, 2018

The files and the graph name need to be bigip_apm_sessions in order for the graphs to appear automatically under the APM tab.

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

JohnSPeach added some commits Oct 24, 2018

Update f5.inc.php
RRD file needs to be named bigip_apm_sessions for the graph to automatically appear.
Update and rename bigip_apm_curr_sessions.inc.php to bigip_apm_sessio…
…ns.inc.php

It seems that both this file and the RRD file need to be named bigip_apm_sessions for the graphs to appear automatically
Create 270.sql
Missed this from the original pull request - the graph has to be named bigip_apm_sessions to automatically display
@murrant
Copy link
Member

left a comment

LGTM, thanks!

@murrant murrant merged commit 03e8bd7 into librenms:master Oct 25, 2018

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP ready for review
Details
codeclimate All good!
Details
license/cla Contributor License Agreement is signed.
Details
@murrant

This comment has been minimized.

Copy link
Member

commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

@lock lock bot locked as resolved and limited conversation to collaborators Dec 28, 2018

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.