New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graph of overall poller performance #9381

Merged
merged 9 commits into from Oct 26, 2018

Conversation

Projects
None yet
3 participants
@murrant
Member

murrant commented Oct 24, 2018

Add new tab on pollers page/menu.
Improve tab layout/display.
Move (copy) poll-log to a tab.
FIXED: Graphs have odd brokenness for me, probably need to build them some other way.

Not 100% sure the calculations are correct.

image

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant murrant changed the title from WIP Graph of overall poller performance to Graph of overall poller performance Oct 25, 2018

@murrant murrant added this to the 1.45 milestone Oct 25, 2018

@TheGreatDoc

This comment has been minimized.

Contributor

TheGreatDoc commented Oct 25, 2018

I will say that at least total time is not correct or Im reading it wrong:

image

3k seconds avg ;)

@murrant

This comment has been minimized.

Member

murrant commented Oct 25, 2018

Remember that this is not real time, it is poller time. Try dividing it by the number of poller threads.

@TheGreatDoc

This comment has been minimized.

Contributor

TheGreatDoc commented Oct 25, 2018

I have 16 threads. 3070 / 16 = 192 seconds.

In my dev install, with 6 devices, poller usually finish in ~10 seconds

@murrant

This comment has been minimized.

Member

murrant commented Oct 25, 2018

@TheGreatDoc Try this:

 find rrd -name poller-perf.rrd| xargs -I{}  rrdtool lastupdate --daemon unix:/run/rrdcached/rrdcached.sock {}|grep :|cut -d' ' -f2|awk 'BEGIN { sum=0 } { sum+=$1 } END {print sum }'

1835.59
@murrant

This comment has been minimized.

Member

murrant commented Oct 25, 2018

Darn test code...

@TheGreatDoc

This comment has been minimized.

Contributor

TheGreatDoc commented Oct 25, 2018

I have rrdcached for production. Dev install is without rrdcached.
How do I get the same without rrdcached?

@murrant

This comment has been minimized.

Member

murrant commented Oct 25, 2018

@TheGreatDoc delete the server option. Also, I fixed the issue.

@TheGreatDoc

This comment has been minimized.

Contributor

TheGreatDoc commented Oct 26, 2018

Tested and looks awesome.

Cur and Min shows 0 like yours. Still working or it is going to be 0? If is going to be 0, can we remove them?

@murrant

This comment has been minimized.

Member

murrant commented Oct 26, 2018

Cur and Min seem to show up on the minis graphs as 0 most of the time. If you click into the graph, they usually show. I'm not sure why this is, but It has something to do with the end time for the graph. I tried to trim time off but it didn't work in a consistent way. So, I've decided it is fine. If someone comes up with a better solution, great.

@@ -364,13 +364,14 @@
<li><a href="{{ url('authlog') }}"><i class="fa fa-shield fa-fw fa-lg" aria-hidden="true"></i> Auth History</a></li>
<li role="presentation" class="divider"></li>
<li class="dropdown-submenu">
<a href="#"><i class="fa fa-th-large fa-fw fa-lg" aria-hidden="true"></i> Pollers</a>

This comment has been minimized.

@laf

laf Oct 26, 2018

Member

The one thing with this change is it makes the sub-menu unusable on a mobile. Clicking the Pollers drop down now just takes you to the pollers page so the sub items in the menu are now only accessible by going to the main pollers page and clicking through the tabs from there.

I'll merge anyway but personally, I think it would be good to restore that.

@laf

laf approved these changes Oct 26, 2018

LGTM. Tested fine.

@laf laf added WebUI and removed Feature Polling labels Oct 26, 2018

@laf laf merged commit 0ec8f18 into librenms:master Oct 26, 2018

2 of 3 checks passed

codeclimate 2 issues to fix
Details
WIP ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@laf laf deleted the murrant:poller-perf-aggregate branch Oct 26, 2018

@murrant

This comment has been minimized.

Member

murrant commented Oct 28, 2018

This pull request has been mentioned on LibreNMS Community. There might be relevant details there:

https://community.librenms.org/t/v1-45-release-changelog-october-2018/6016/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment