Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

php artisan serve and dusk testing #9422

Merged
merged 17 commits into from Feb 14, 2019

Conversation

Projects
None yet
2 participants
@murrant
Copy link
Member

commented Nov 6, 2018

Easier web development with php artisan serve
And webui testing using Laravel Dusk

Needs #8868

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@laf

This comment has been minimized.

Copy link
Member

commented Nov 8, 2018

Anything you need testing specifically? Things like ajax calls don't seem to work.

@laf laf added the Feature label Nov 8, 2018

@murrant

This comment has been minimized.

Copy link
Member Author

commented Nov 10, 2018

Yeah, I wanted this for some new Laravel pages I added and it was non-trivial so I split it out to its own PR.

@laf

This comment has been minimized.

Copy link
Member

commented Nov 17, 2018

Rebased to fix travis.

@murrant murrant force-pushed the murrant:fix-serve branch from ddd1874 to 6028cd1 Nov 19, 2018

@murrant murrant referenced this pull request Dec 21, 2018

Merged

New User Management #9348

1 of 1 task complete

@murrant murrant force-pushed the murrant:fix-serve branch from dd9ec05 to eea9040 Jan 16, 2019

@murrant murrant force-pushed the murrant:fix-serve branch from eea9040 to 9fd4f23 Feb 14, 2019

murrant added some commits Feb 14, 2019

Update tests
fix migrations

@murrant murrant merged commit 63de34e into librenms:master Feb 14, 2019

5 of 6 checks passed

codeclimate Code Climate encountered an error attempting to analyze this pull request.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

@murrant murrant deleted the murrant:fix-serve branch Feb 16, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Apr 17, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.