Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Junos CPU Discovery #9467

Merged
merged 4 commits into from Feb 16, 2019

Conversation

Projects
None yet
5 participants
@Rosiak
Copy link
Contributor

commented Nov 20, 2018

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

  • 1st commit add's a proper description to the polled SRX processors, instead of the generic "CPU".
  • 2nd commit add's changes the way invalid sensors are skipped, as CPU usage on some elements could return 0 during inactive periods, which would cause the sensor to be removed upon discovery. Tested on MX,SRX,EX. It's a bit hacky but works.

Indexes remains unchanged.

@murrant

This comment has been minimized.

Copy link
Member

commented Nov 20, 2018

You'll need to add some updated test data because our test data didn't capture that oid...

@Rosiak

This comment has been minimized.

Copy link
Contributor Author

commented Nov 20, 2018

Will do.

@evheros

This comment has been minimized.

Copy link
Contributor

commented Jan 21, 2019

Any update on this one? I see the problem on one of my installs with processor beeing removed so would be nice if we can proceed with this PR.
I tried to get the testdata but my Juniper (QFX) doesn't provide this OID.

@Rosiak

This comment has been minimized.

Copy link
Contributor Author

commented Jan 21, 2019

I'll see if I get time to supply the test data, sorry for the wait-time.

@sjohnson1980

This comment has been minimized.

Copy link

commented Jan 30, 2019

Here is some sample data from 4 different platforms, limited to everything under jnxOperatingTable, to show relevant data and limit possibly sensitive information.

Let me know if you need the output of more OIDs.

Thanks.

snmprec_jnxOperatingTable_srx1500.txt
snmprec_jnxOperatingTable_qfx5100.txt
snmprec_jnxOperatingTable_qfx10k.txt
snmprec_jnxOperatingTable_ex3400.txt

@murrant

This comment has been minimized.

Copy link
Member

commented Jan 31, 2019

@sjohnson1980 thanks, but none of these contain 1.3.6.1.4.1.2636.3.39.1.12.1.1.1.4 or .1.3.6.1.4.1.2636.3.1.13.1.11...

If you concerned about the amount of data, it is easy to limit it.

  1. First, apply this PR ./scripts/github-apply 9467
  2. Then capture minimum data ./scripts/collect-snmp-data.php -h HOSTNAME -m processors -v srx1500 (or whatever for -v)
@sjohnson1980

This comment has been minimized.

Copy link

commented Jan 31, 2019

1.3.6.1.4.1.2636.3.1.13.1.11 was there for all of them, but indeed, none of them had 1.3.6.1.4.1.2636.3.39.1.12.1.1.1.4.

Here's the data with only the -m processors
junos_mx104.snmprec.txt
junos_srx1500.snmprec.txt
junos_qfx5100.snmprec.txt
junos_qfx10k.snmprec.txt
junos_ex3400.snmprec.txt

Thanks!

@sjtarik

This comment has been minimized.

Copy link
Contributor

commented Feb 4, 2019

any progress on this? I see this issue on juniper qfx monitoring.

sjtarik added a commit to sjtarik/librenms that referenced this pull request Feb 5, 2019

@sjtarik

This comment has been minimized.

Copy link
Contributor

commented Feb 5, 2019

Hey @murrant, @sjohnson1980,

I need this fix, I uploaded a test file with the particular OID. Let me know if you need additional help.

murrant added a commit that referenced this pull request Feb 7, 2019

@murrant murrant force-pushed the Rosiak:junos-cpu-fixes branch from 63cbf4c to cc18fe3 Feb 16, 2019

@murrant murrant merged commit ae7e262 into librenms:master Feb 16, 2019

5 of 6 checks passed

codeclimate Code Climate is analyzing this code.
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details

sjtarik added a commit to sjtarik/librenms that referenced this pull request Feb 19, 2019

@lock lock bot locked as resolved and limited conversation to collaborators Apr 17, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.