Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Vigintos Modulator & Ampiflier #9488

Merged
merged 24 commits into from Jan 11, 2019
Merged

Added support for Vigintos Modulator & Ampiflier #9488

merged 24 commits into from Jan 11, 2019

Conversation

jozefrebjak
Copy link
Contributor

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

@murrant
Copy link
Member

murrant commented Dec 21, 2018

@jozefrebjak Looks like you could have used yaml for this any reason not to?

It looks like you just set it to the host2DevParTable and use skip_values on host2DevParName to specify what type of sensor it is. (I don't have full device data, so I can't tell if that is correct)

@@ -0,0 +1,41 @@
VEL-MIB DEFINITIONS ::= BEGIN
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MIB directory should match the os name. (you have an extra i here)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was mistake, I changed it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you :)

@jozefrebjak
Copy link
Contributor Author

@murrant I did it like this because, all of these sensors are on the same OID, here is how it is look like

snimka obrazovky 2018-12-21 o 22 22 48

maybe there is possibility how to do it in yaml, but when I tried then I get values from current in voltage for example.

@jozefrebjak
Copy link
Contributor Author

There is how it is looks like in a web, its something like host controller for DVB modulator and amplifier

snimka obrazovky 2018-12-21 o 22 33 00
snimka obrazovky 2018-12-21 o 22 32 51

@murrant
Copy link
Member

murrant commented Dec 22, 2018

I'm saying according to the MIB it doesn't guarantee they will always be at those OIDs (on different devices). It is just a list of values.

It might be more reliable to use host2DevParUnit to determine what type of sensor it is.

@murrant
Copy link
Member

murrant commented Jan 9, 2019

@jozefrebjak how are you coming along with this?

@murrant murrant added Device 🖥️ New or added device support User-Pending Currently waiting for user response labels Jan 9, 2019
@jozefrebjak
Copy link
Contributor Author

@murrant so, i deleted all php discovery and replaced them with yaml. I used your advice to do this.

@murrant murrant removed the User-Pending Currently waiting for user response label Jan 10, 2019
Copy link
Member

@murrant murrant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge. If you are happy with it @jozefrebjak go ahead and remove the WIP from the title.

@jozefrebjak jozefrebjak changed the title WIP Added support for Vigintos Modulator & Ampiflier Added support for Vigintos Modulator & Ampiflier Jan 10, 2019
@murrant murrant merged commit 4c058ae into librenms:master Jan 11, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Mar 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Device 🖥️ New or added device support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants