New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for Vigintos Modulator & Ampiflier #9488
Conversation
@jozefrebjak Looks like you could have used yaml for this any reason not to? It looks like you just set it to the host2DevParTable and use skip_values on host2DevParName to specify what type of sensor it is. (I don't have full device data, so I can't tell if that is correct) |
mibs/viginitos/VEL-MIB
Outdated
@@ -0,0 +1,41 @@ | |||
VEL-MIB DEFINITIONS ::= BEGIN |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The MIB directory should match the os name. (you have an extra i here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it was mistake, I changed it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you :)
@murrant I did it like this because, all of these sensors are on the same OID, here is how it is look like maybe there is possibility how to do it in yaml, but when I tried then I get values from current in voltage for example. |
I'm saying according to the MIB it doesn't guarantee they will always be at those OIDs (on different devices). It is just a list of values. It might be more reliable to use host2DevParUnit to determine what type of sensor it is. |
@jozefrebjak how are you coming along with this? |
@murrant so, i deleted all php discovery and replaced them with yaml. I used your advice to do this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge. If you are happy with it @jozefrebjak go ahead and remove the WIP from the title.
DO NOT DELETE THIS TEXT
Please note
Testers
If you would like to test this pull request then please run:
./scripts/github-apply <pr_id>
, i.e./scripts/github-apply 5926
After you are done testing, you can remove the changes with
./scripts/github-remove
. If there are schema changes, you can ask on discord how to revert.