New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set $inverse to TRUE when the GET option is set #955

Merged
merged 1 commit into from May 10, 2015

Conversation

Projects
None yet
2 participants
@mmarchand
Contributor

mmarchand commented May 10, 2015

Fixes #948

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 10, 2015

Member

Hi @mmarchand

Thanks for the PR. Normally we need a contributor agreement but I think we'll be ok on this one. For future bigger contributions can you submit one, this is an example: #953

As for this PR itself, any reason not to just get rid of the $in / $out section as it doesn't seem to be needed. The PR would then look like:

if ($_GET['inverse']) {
    $inverse=TRUE;
} 
Member

laf commented May 10, 2015

Hi @mmarchand

Thanks for the PR. Normally we need a contributor agreement but I think we'll be ok on this one. For future bigger contributions can you submit one, this is an example: #953

As for this PR itself, any reason not to just get rid of the $in / $out section as it doesn't seem to be needed. The PR would then look like:

if ($_GET['inverse']) {
    $inverse=TRUE;
} 
@mmarchand

This comment has been minimized.

Show comment
Hide comment
@mmarchand

mmarchand May 10, 2015

Contributor

Noted for the agreement :)
(and I do I agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md)
for $in and $out, it's actually used in other scripts (for example html/includes/graphs/generic_multi_bits_separated.inc.php ), it is used to actually "invert" the datasources from the RRD

Contributor

mmarchand commented May 10, 2015

Noted for the agreement :)
(and I do I agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md)
for $in and $out, it's actually used in other scripts (for example html/includes/graphs/generic_multi_bits_separated.inc.php ), it is used to actually "invert" the datasources from the RRD

@laf

This comment has been minimized.

Show comment
Hide comment
@laf

laf May 10, 2015

Member

You are indeed correct :)

Member

laf commented May 10, 2015

You are indeed correct :)

laf added a commit that referenced this pull request May 10, 2015

Merge pull request #955 from mmarchand/issue-948
Set $inverse to TRUE when the GET option is set

@laf laf merged commit 960ecad into librenms:master May 10, 2015

1 check passed

Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment