Set $inverse to TRUE when the GET option is set #955

Merged
merged 1 commit into from May 10, 2015

Projects

None yet

2 participants

@mmarchand
Contributor

Fixes #948

@laf
Member
laf commented May 10, 2015

Hi @mmarchand

Thanks for the PR. Normally we need a contributor agreement but I think we'll be ok on this one. For future bigger contributions can you submit one, this is an example: #953

As for this PR itself, any reason not to just get rid of the $in / $out section as it doesn't seem to be needed. The PR would then look like:

if ($_GET['inverse']) {
    $inverse=TRUE;
} 
@mmarchand
Contributor

Noted for the agreement :)
(and I do I agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md)
for $in and $out, it's actually used in other scripts (for example html/includes/graphs/generic_multi_bits_separated.inc.php ), it is used to actually "invert" the datasources from the RRD

@laf
Member
laf commented May 10, 2015

You are indeed correct :)

@laf laf merged commit 960ecad into librenms:master May 10, 2015

1 check passed

Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment