New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aggregates on multi_bits_separate graphs #956

Merged
merged 4 commits into from May 10, 2015

Conversation

Projects
None yet
2 participants
@mmarchand
Contributor

mmarchand commented May 10, 2015

Adds an aggregate legend with the total of all ports specified
Add nodetails option to lighten the legend when adding lots of ports on one graph
Small fix for nototal which was not working anymore

I am just not sure about padding of texts ... it works here though (adding some pics as examples of all options combinations)

I agree to the conditions of the Contributor Agreement contained in doc/General/Contributing.md

graph.php?height=140&width=520&legend=yes&id=357,358,359&type=multiport_bits_separate&from=-8h&nodetails=1&nototal=1
nodetailnototal
graph.php?height=140&width=520&legend=yes&id=357,358,359&type=multiport_bits_separate&from=-8h&nodetails=1
nodetails
graph.php?height=140&width=520&legend=yes&id=357,358,359&type=multiport_bits_separate&from=-8h&nototal=1
nototal
graph.php?height=140&width=520&legend=yes&id=357,358,359&type=multiport_bits_separate&from=-8h
withdetails

fixed nototal option which was not properly set in common.inc.php
add new nodetails option to not display each device/port on the legend when graphing lots of devices
add new aggregates on multibits graphs

@f0o f0o self-assigned this May 10, 2015

@f0o

This comment has been minimized.

Show comment
Hide comment
@f0o

f0o May 10, 2015

Member

Hi @mmarchand,

Thanks for contributing, I'm just to review your PR and do a quick function test before merge.

Meanwhile, can you please sign the Contributor's Agreement?
See #953 as reference on how to sign it :)

Member

f0o commented May 10, 2015

Hi @mmarchand,

Thanks for contributing, I'm just to review your PR and do a quick function test before merge.

Meanwhile, can you please sign the Contributor's Agreement?
See #953 as reference on how to sign it :)

@mmarchand

This comment has been minimized.

Show comment
Hide comment
@mmarchand

mmarchand May 10, 2015

Contributor

ha just understood it needs a commit, will do, thanks :)

Contributor

mmarchand commented May 10, 2015

ha just understood it needs a commit, will do, thanks :)

@f0o

This comment has been minimized.

Show comment
Hide comment
@f0o

f0o May 10, 2015

Member

A small question.

When adding &nodetails=1 and &nototal=1 it still shows the aggregates. I think it would make sense adding a &noagg=1 (or therelike) to follow it's lead :)

Apart from that 👍

Member

f0o commented May 10, 2015

A small question.

When adding &nodetails=1 and &nototal=1 it still shows the aggregates. I think it would make sense adding a &noagg=1 (or therelike) to follow it's lead :)

Apart from that 👍

@mmarchand

This comment has been minimized.

Show comment
Hide comment
@mmarchand

mmarchand May 10, 2015

Contributor

yes , it makes sense, adding the noagg option :)

Contributor

mmarchand commented May 10, 2015

yes , it makes sense, adding the noagg option :)

@f0o

This comment has been minimized.

Show comment
Hide comment
@f0o

f0o May 10, 2015

Member

Thanks!

Member

f0o commented May 10, 2015

Thanks!

@f0o

This comment has been minimized.

Show comment
Hide comment
@f0o

f0o May 10, 2015

Member

A last tiny thing. After adding nodetails,nototal and noagg it still shows the Header of the fields, can you strip those?
See: https://librenms.devilcode.org/graph.php?height=140&width=520&legend=yes&id=75,76&type=multiport_bits_separate&from=-8h&nototal=1&nodetails=1&noagg=1

Member

f0o commented May 10, 2015

A last tiny thing. After adding nodetails,nototal and noagg it still shows the Header of the fields, can you strip those?
See: https://librenms.devilcode.org/graph.php?height=140&width=520&legend=yes&id=75,76&type=multiport_bits_separate&from=-8h&nototal=1&nodetails=1&noagg=1

@mmarchand

This comment has been minimized.

Show comment
Hide comment
@mmarchand

mmarchand May 10, 2015

Contributor

sure, looking into it :)

Contributor

mmarchand commented May 10, 2015

sure, looking into it :)

@f0o

This comment has been minimized.

Show comment
Hide comment
@f0o

f0o May 10, 2015

Member

Good job :)
Merging

//Edit: just need to wait for scrut to finish

Member

f0o commented May 10, 2015

Good job :)
Merging

//Edit: just need to wait for scrut to finish

f0o added a commit that referenced this pull request May 10, 2015

Merge pull request #956 from mmarchand/aggregate
Add aggregates on multi_bits_separate graphs

@f0o f0o merged commit e4490f1 into librenms:master May 10, 2015

1 check passed

Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment