Fix ifalias parsing #960

Merged
merged 2 commits into from May 12, 2015

Projects

None yet

3 participants

@mmarchand
Contributor

When ifAlias contains "=" , the end of string is lost

mmarchand added some commits May 11, 2015
@mmarchand mmarchand Fix ifAlias parsing when the description contains "="
It might also fix a few other parsing issues involving "=" in other snmp fields
8705dfa
@mmarchand mmarchand Merge branch 'master' of https://github.com/librenms/librenms into fi…
…xifaliasparse
9098e81
@laf
Member
laf commented May 11, 2015

Thanks for the PR @mmarchand

I don't see any issue with this. I'll chuck it on a test install for a little while.

@paulgear and @f0o Tagging you guys for comments.

@laf laf added the bug label May 11, 2015
@paulgear
Member

Seems sensible to me; just curious @mmarchand - what sort of devices have = in the ifAlias?

@laf
Member
laf commented May 12, 2015

I ran it overnight with no issues. I'll merge in today

@laf laf self-assigned this May 12, 2015
@laf laf merged commit ebc6908 into librenms:master May 12, 2015

1 check passed

Scrutinizer No new issues
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment