Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed legacy transports and templates code #9646

Merged
merged 8 commits into from Feb 15, 2019

Conversation

Projects
None yet
3 participants
@laf
Copy link
Member

commented Jan 10, 2019

@murrant

This comment has been minimized.

Copy link
Member

commented Feb 11, 2019

Does this actually remove legacy transports? Or just templates?

@murrant
Copy link
Member

left a comment

LGTM, the email alerting needs to be cleaned up :/

@murrant murrant force-pushed the laf:remove-legacy-templates-transports branch from 0497db0 to 76ab676 Feb 15, 2019

murrant added some commits Feb 15, 2019

Prevent no contacts error when default contact is not specified, or t…
…here are no contacts for other reasons.
Show resolved Hide resolved misc/notifications.rss Outdated

Resolved

@murrant murrant merged commit 5d74839 into librenms:master Feb 15, 2019

5 of 6 checks passed

codeclimate 1 issue to fix
Details
Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
license/cla Contributor License Agreement is signed.
Details
@TheGreatDoc

This comment has been minimized.

Copy link
Contributor

commented Feb 15, 2019

@murrant you left the year untouched 😄

@murrant

This comment has been minimized.

Copy link
Member

commented Feb 15, 2019

Oopsie

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Removed legacy transports and templates code (librenms#9646)
* Removed legacy transports and templates code

* Add notification

* abstract LnmsCommand

* Only issue alerts "legacy" alerts to mail for default contacts, etc.

* Prevent no contacts error when default contact is not specified, or there are no contacts for other reasons.

* remove eval \o/

* Update notifications.rss

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.