Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data scrubbing state to Synology RAID status #9661

Merged
merged 3 commits into from Mar 4, 2019

Conversation

Projects
None yet
3 participants
@florianbeer
Copy link
Contributor

commented Jan 14, 2019

Adds a new state translation to Synology DSM RAID status sensor, so it displays "DataScrubbing" while the operation is running. Previously it would just show "# 13".

DO NOT DELETE THIS TEXT

Please note

Please read this information carefully. You can run ./scripts/pre-commit.php to check your code before submitting.

Testers

If you would like to test this pull request then please run: ./scripts/github-apply <pr_id>, i.e ./scripts/github-apply 5926
After you are done testing, you can remove the changes with ./scripts/github-remove. If there are schema changes, you can ask on discord how to revert.

Add data scrubbing state to Synology RAID status
Adds a new state translation to Synology DSM RAID status sensor, so it displays "DataScrubbing" while the operation is running. Previously it would just show "# 13".
@CLAassistant

This comment has been minimized.

Copy link

commented Jan 14, 2019

CLA assistant check
All committers have signed the CLA.

@florianbeer florianbeer referenced this pull request Jan 14, 2019

Closed

Update Synology RAID MIB #9662

0 of 1 task complete

@florianbeer florianbeer force-pushed the florianbeer:patch-1 branch from e76fd4e to 4e49069 Jan 14, 2019

@murrant
Copy link
Member

left a comment

Needs to be converted to yaml or updated PHP. Otherwise existing state translations won't be updated.

@florianbeer

This comment has been minimized.

Copy link
Contributor Author

commented Jan 17, 2019

Alright, I'll attempt to convert this to yaml. I'm just swamped at work at the moment so this might take a bit, please bear with me

@murrant

This comment has been minimized.

Copy link
Member

commented Jan 17, 2019

Thanks @florianbeer

@murrant murrant removed the User-Pending label Mar 4, 2019

@murrant

murrant approved these changes Mar 4, 2019

@murrant murrant merged commit 80d0a23 into librenms:master Mar 4, 2019

6 checks passed

Inspection Summary
Details
Node: analysis
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codeclimate 1 fixed issue
Details
license/cla Contributor License Agreement is signed.
Details

@florianbeer florianbeer deleted the florianbeer:patch-1 branch Mar 4, 2019

funzoneq added a commit to funzoneq/librenms that referenced this pull request Apr 30, 2019

Add data scrubbing state to Synology RAID status (librenms#9661)
* Add data scrubbing state to Synology RAID status

Adds a new state translation to Synology DSM RAID status sensor, so it displays "DataScrubbing" while the operation is running. Previously it would just show "# 13".

* Update Synology RAID MIB

Downloaded from
https://global.download.synology.com/download/Document/MIBGuide/Synology_MIB_File.zip

@lock lock bot locked as resolved and limited conversation to collaborators May 3, 2019

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.